Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sbt-scoverage #458

Closed
wants to merge 1 commit into from
Closed

Update sbt-scoverage #458

wants to merge 1 commit into from

Conversation

johnynek
Copy link
Collaborator

This may be working now with more recent versions of the plugins. The report seems to work on my machine (98% coverage for algebird-core, if correct).

@travisbrown
Copy link
Contributor

I'm pretty sure sbt-scoverage 1.1.0 won't work nicely with Coveralls until sbt-coveralls 1.1.0 comes out (see my comment here)—we're had to stick with sbt-scoverage 1.0.4 and sbt-coveralls 1.0.0 in other projects. I guess it's worth a try here, though.

@johnynek
Copy link
Collaborator Author

any idea how to disable the build staying yellow waiting for coveralls if we can't get it to run? It's really annoying.

It's sad how broken all this stuff is. I hate to dump on open source projects, but typesafe or even Twitter should pay if needed to make this work. This has yet to give us good data for any of our projects when run with Travis, as far as I know. Have you been able to get the finagle stack working with it?

<insert envy that the analytics stack doesn't get as much of your time as finagle does>

@travisbrown
Copy link
Contributor

I've got a review out right now adding Coveralls reporting to six Finagle-related projects, and that part was relatively painless—see e.g.:

https://github.com/travisbrown/util
https://github.com/travisbrown/scrooge
https://github.com/travisbrown/ostrich

We switched Finch from Coveralls to Codecov as an experiment and it's definitely been vastly less fussy than Coveralls. Scoverage itself is I think fairly solid, and Codecov works directly with its reports (there's no separate sbt-codecov plugin—you just add bash <(curl -s https://codecov.io/bash) to after_success).

@ianoc ianoc closed this Aug 4, 2015
@ianoc
Copy link
Collaborator

ianoc commented Aug 4, 2015

Sorry my bad, git foo on cmd line broke stuff and closed all of these

@ianoc ianoc reopened this Aug 4, 2015
@DanielleSucher
Copy link
Collaborator

Ping on this! Is it worth considering switching to Codecov here too?

@johnynek
Copy link
Collaborator Author

johnynek commented Sep 8, 2015

@DanielleSucher I think that would be awesome.

@johnynek
Copy link
Collaborator Author

let's just focus on #414

@johnynek johnynek closed this Nov 18, 2015
@johnynek johnynek deleted the oscar/fix-coverage branch November 18, 2015 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants