Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tuple1 bijections #249

Merged
merged 1 commit into from
Jun 14, 2016

Conversation

Olshansk
Copy link

  • Add support for Bufferable injection from Tuple1[T] to Array[Byte]
  • Add support for injection from a case class with one element to a
    Tuple1[T]

Testing:
$ ./sbt bijection-macros/console

scala> import com.twitter.bijection.{Bijection, Bufferable, Injection, macros}
scala> import macros._
scala> import MacroImplicits._
scala> case class Foo(v: Long)
scala> implicit val fooToByteArray = Bufferable.injectionOf[Tuple1[Long]]
scala> val fooInjection = Injection.connect[Foo, Tuple1[Long], Array[Byte]]

- Add support for Bufferable injection from Tuple1[T] to Array[Byte]
- Add support for injection from a case class with one element to a
Tuple1[T]

Testing:
$ ./sbt bijection-macros/console

scala> import com.twitter.bijection.{Bijection, Bufferable, Injection, macros}
scala> import macros._
scala> import MacroImplicits._
scala> case class Foo(v: Long)
scala> implicit val fooToByteArray = Bufferable.injectionOf[Tuple1[Long]]
scala> val fooInjection = Injection.connect[Foo, Tuple1[Long], Array[Byte]]
@johnynek
Copy link
Collaborator

Thanks for the improvement!

@johnynek johnynek merged commit c23a908 into twitter:develop Jun 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants