Filter restartable effects explicitly #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenyee
approved these changes
Sep 26, 2022
| // From https://developer.android.com/jetpack/compose/side-effects#restarting-effects | ||
| private val RestartableEffects by lazy(LazyThreadSafetyMode.NONE) { | ||
| setOf( | ||
| "LaunchedEffect", |
There was a problem hiding this comment.
would this ever need to be externally configurable like the emissions Composable list?
There was a problem hiding this comment.
Not the list of restartable effects per se, but it would be nice to add them as an extra list of things allowed in ViewModelForwarding (eg you have a composable that uses the VM for keying). Can't think of an use case on the top of my head but I'm sure it could be useful to support. And given that the cost of adding it to the config is minimal, I'll do that 😆
Will do this in a separate patch though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
ComposeViewModelForwardingwe were blank checking that*Effectwas not used. In reality, the list of restartable effects is smaller and we could keep it up to date ourselves.