"sealed abstract" is not necessary since "sealed" is enough. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a trait as "abstract" is somewhat confusing because a trait is abstract by definition.
mariusae
added a commit
that referenced
this pull request
Feb 8, 2012
"sealed abstract" is not necessary since "sealed" is enough.
akirakoyasu
pushed a commit
to akirakoyasu/effectivescala
that referenced
this pull request
Sep 4, 2014
akirakoyasu
pushed a commit
to akirakoyasu/effectivescala
that referenced
this pull request
Sep 4, 2014
mariusae
pushed a commit
that referenced
this pull request
Jan 26, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed "abstract" from "sealed abstract" since it is somewhat confusing.
A trait is abstract by definition so there is no need to declare it abstract again.
sealed trait A case object B extends A case object C extends Ais the same as
sealed abstract trait A case object B extends A case object C extends A