finagle-core: Promote DarkTrafficFilter from finagle-exp

Problem `DarkTrafficFilter` and `AbstractDarkTrafficFilter` are no longer experimental as we should inform those who use it when changes occur and develop backwards compatibility for it moving forward. Solution Move it out of the experimental directory into finagle-core with the other filters. JIRA Issues: CSL-3026 Differential Revision: https://phabricator.twitter.biz/D572384
twitter · Oct 30, 2020 · 0ecaa5e · 0ecaa5e
1 parent 931785d
commit 0ecaa5e
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 4 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -14,6 +14,13 @@ New Features
   `SslClientEngineFactory` acts as a better example of how to build custom client and server engine
   factories in order to reuse SSL contexts for performance concerns. ``PHAB_ID=D572567``
 
+Breaking API Changes
+~~~~~~~~~~~~~~~~~~~~
+
+* finagle-core: Move `DarkTrafficFilter` and `AbstractDarkTrafficFilter` from the experimental
+  finagle-exp to supported finagle-core. The package containing these classes changed from
+  `c.t.finagle.exp` to `c.t.finagle.filter`. ``PHAB_ID=D572384``
+
 20.10.0
 -------
 

diff --git a/...nagle/exp/AbstractDarkTrafficFilter.scala → ...le/filter/AbstractDarkTrafficFilter.scala b/...nagle/exp/AbstractDarkTrafficFilter.scala → ...le/filter/AbstractDarkTrafficFilter.scala
@@ -1,7 +1,7 @@
-package com.twitter.finagle.exp
+package com.twitter.finagle.filter
 
 import com.twitter.finagle.Service
-import com.twitter.finagle.exp.DarkTrafficFilter.DarkRequestAnnotation
+import com.twitter.finagle.filter.DarkTrafficFilter.DarkRequestAnnotation
 import com.twitter.finagle.stats.StatsReceiver
 import com.twitter.finagle.tracing.ForwardAnnotation
 import com.twitter.util.{Future, Promise}

diff --git a/...itter/finagle/exp/DarkTrafficFilter.scala → ...er/finagle/filter/DarkTrafficFilter.scala b/...itter/finagle/exp/DarkTrafficFilter.scala → ...er/finagle/filter/DarkTrafficFilter.scala
@@ -1,4 +1,4 @@
-package com.twitter.finagle.exp
+package com.twitter.finagle.filter
 
 import com.twitter.finagle._
 import com.twitter.finagle.stats.StatsReceiver

diff --git a/...r/finagle/exp/DarkTrafficFilterTest.scala → ...inagle/filter/DarkTrafficFilterTest.scala b/...r/finagle/exp/DarkTrafficFilterTest.scala → ...inagle/filter/DarkTrafficFilterTest.scala
@@ -1,4 +1,4 @@
-package com.twitter.finagle.exp
+package com.twitter.finagle.filter
 
 import com.twitter.conversions.DurationOps.RichDuration
 import com.twitter.finagle.client.utils.StringClient