Skip to content

Commit

Permalink
Remove deprecated methods from c.t.f.http.Response
Browse files Browse the repository at this point in the history
Remove the deprecated `setStatusCode` and `getStatusCode` methods
from `c.t.f.http.Response`.

JIRA Issues: CSL-7774

Differential Revision: https://phabricator.twitter.biz/D326326
  • Loading branch information
Bryce Anderson authored and jenkins committed Jun 19, 2019
1 parent 37fa238 commit 20b37b0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ Unreleased
Breaking API Changes
~~~~~~~~~~~~~~~~~~~~

* finagle-base-http: Removed the methods `setStatusCode` and `getStatusCode` from
`c.t.f.http.Response` which have been deprecated since 2017. ``PHAB_ID=D326326``

* finagle-core: A long deprecated `c.t.f.builder.ServerBuilder#build` method, which
takes a `Service[Req, Rep]` and a not fully specified config as params, has been
removed. ``PHAB_ID=D330348``
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,6 @@ abstract class Response private extends Message {
this
}

/** Get the status code of this response */
@deprecated("2017-02-17", "Use [[statusCode]] instead")
final def getStatusCode(): Int = statusCode

/** Set the status code of this response */
@deprecated("2017-02-17", "Use [[statusCode(Int)]] instead")
final def setStatusCode(value: Int): Unit = { statusCode = value }

override def toString =
"Response(\"" + version + " " + status + "\")"
}
Expand Down

0 comments on commit 20b37b0

Please sign in to comment.