-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
finagle-http: Remove Misleading MaxRequest/MaxResponse Size Methods
Problem The `MaxRequestSize` param within Finagle HTTP is applicable to Finagle HTTP servers only. The `MaxResponseSize` param is applicable to Finagle HTTP clients only. It is incorrect and misleading to have a `client.withMaxRequestSize(size)` method and a `server.withMaxResponseSize(size)` method, since while they change the underlying `Stack` params for that client or server, changing that `Stack` param for that particular side has no effect. Solution Remove the `client.withMaxRequestSize(size)` and `server.withMaxResponseSize(size)` methods, and more clearly document the underlying params to indicate that `MaxRequestSize` is for HTTP servers only, and `MaxResponseSize` is for HTTP clients only. JIRA Issues: CSL-8121 Differential Revision: https://phabricator.twitter.biz/D314019
- Loading branch information
1 parent
d48c02f
commit 5eb3ae2
Showing
3 changed files
with
21 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters