Skip to content

Commit

Permalink
finagle-benchmark: Make sure the code compiles
Browse files Browse the repository at this point in the history
Summary: Problem

This commit [1] broke a public API in Zk2Resolver's constructors.
For code with diamond dependencies this can cause problems.

Solution

This change use a constructor available in both implementations
to unblock developers.

[1] a9bb335

Differential Revision: https://phabricator.twitter.biz/D106064
  • Loading branch information
kevinoliver authored and jenkins committed Oct 31, 2017
1 parent 7c08401 commit 77b3ec9
Showing 1 changed file with 1 addition and 4 deletions.
Expand Up @@ -59,10 +59,7 @@ class ServerSetResolver {

val stabilizationWindow = Duration.fromSeconds(stabilizationSec)
val resolver = new Zk2Resolver(
NullStatsReceiver,
stabilizationWindow,
stabilizationWindow,
stabilizationWindow
NullStatsReceiver
)

val serverSetPaths = LocalServerSetService.createServerSetPaths(serverSetsToResolve)
Expand Down

0 comments on commit 77b3ec9

Please sign in to comment.