finagle: upgrade to Netty 4.1.35.Final and netty-tcnative 2.0.25.Final

Problem/Solution

Upgrade Netty to 4.1.35.Final and netty-tcnative to 2.0.25.Final
and change `c.t.f.netty4.http.handler.FixedLengthMessageAggregator` to leverage
the Netty `isStartMessage` change (netty/netty#8793).

JIRA Issues: CSL-7908

Differential Revision: https://phabricator.twitter.biz/D312439

CHANGELOG.rst

@@ -7,6 +7,9 @@ Note that ``PHAB_ID=#`` and ``RB_ID=#`` correspond to associated messages in com
 Unreleased
 ----------
 
+* finagle: Upgrade to Netty 4.1.35.Final and netty-tcnative 2.0.25.Final. 
+  ``PHAB_ID=D312439``
+
 19.5.1
 ------
 

build.sbt

@@ -6,7 +6,7 @@ val releaseVersion = "19.6.0-SNAPSHOT"
 
 val libthriftVersion = "0.10.0"
 
-val netty4Version = "4.1.31.Final"
+val netty4Version = "4.1.35.Final"
 
 // zkVersion should be kept in sync with the 'util-zk' dependency version
 val zkVersion = "3.5.0-alpha"
@@ -32,7 +32,7 @@ val netty4LibsTest = Seq(
 )
 val netty4Http = "io.netty" % "netty-codec-http" % netty4Version
 val netty4Http2 = "io.netty" % "netty-codec-http2" % netty4Version
-val netty4StaticSsl = "io.netty" % "netty-tcnative-boringssl-static" % "2.0.19.Final"
+val netty4StaticSsl = "io.netty" % "netty-tcnative-boringssl-static" % "2.0.25.Final"
 val opencensusVersion = "0.19.1"
 val jacksonVersion = "2.9.8"
 val jacksonLibs = Seq(

finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/handler/FixedLengthMessageAggregator.scala

@@ -31,26 +31,9 @@ private[http] class FixedLengthMessageAggregator(
     extends FinagleHttpObjectAggregator(maxContentLength.inBytes.toInt, handleExpectContinue) {
   require(maxContentLength.bytes >= 0)
 
-  private[this] var decoding = false
-
-  override def acceptInboundMessage(msg: Any): Boolean = msg match {
-    case _: FullHttpMessage =>
-      false
-
-    case msg: HttpMessage if shouldAggregate(msg) =>
-      decoding = true
-      true
-
-    case _: HttpContent if decoding =>
-      true
-
-    case _ =>
-      false
-  }
-
-  override def finishAggregation(aggregated: FullHttpMessage): Unit = {
-    decoding = false
-    super.finishAggregation(aggregated)
+  override def isStartMessage(msg: HttpObject): Boolean = msg match {
+    case httpMsg: HttpMessage => shouldAggregate(httpMsg)
+    case _ => false
   }
 
   private[this] def shouldAggregate(msg: HttpMessage): Boolean = {