finagle-netty4: Change "connection_requests" stat to Debug verbosity

Problem This stat isn't all that helpful, mostly adding noise and cost to operating services. Solution Change the stat to Debug level verbosity. JIRA Issues: CSL-5313 Differential Revision: https://phabricator.twitter.biz/D391289
twitter · Nov 8, 2019 · a6dc129 · a6dc129
1 parent 77fd0f5
commit a6dc129
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -7,6 +7,9 @@ Note that ``PHAB_ID=#`` and ``RB_ID=#`` correspond to associated messages in com
 Unreleased
 ----------
 
+* finagle-netty4: Change the 'connection_requests' metric to debug verbosity.
+  ``PHAB_ID=D391289``
+
 19.11.0
 -------
 
@@ -44,6 +47,7 @@ Runtime Behavior Changes
 
 * finagle-serversets: `finagle/serverset2/stabilizer/notify_ms` histogram has been downgraded to
   debug verbosity. ``PHAB_ID=D392265``
+>>>>>>> master
 
 Breaking API Changes
 ~~~~~~~~~~~~~~~~~~~~

diff --git a/doc/src/sphinx/metrics/Transport.rst b/doc/src/sphinx/metrics/Transport.rst
@@ -27,7 +27,7 @@ ServerBridge
 ChannelRequestStatsHandler
 <<<<<<<<<<<<<<<<<<<<<<<<<<
 
-**connection_requests**
+**connection_requests** `verbosity:debug`
   A histogram of the number of requests received over the lifetime of a
   connection.
 

diff --git a/...netty4/src/main/scala/com/twitter/finagle/netty4/channel/ChannelRequestStatsHandler.scala b/...netty4/src/main/scala/com/twitter/finagle/netty4/channel/ChannelRequestStatsHandler.scala
@@ -1,7 +1,7 @@
 package com.twitter.finagle.netty4.channel
 
 import com.twitter.finagle.netty4.channel.ChannelRequestStatsHandler.SharedChannelRequestStats
-import com.twitter.finagle.stats.StatsReceiver
+import com.twitter.finagle.stats.{StatsReceiver, Verbosity}
 import io.netty.channel._
 
 private object ChannelRequestStatsHandler {
@@ -11,7 +11,7 @@ private object ChannelRequestStatsHandler {
    * or server.
    */
   class SharedChannelRequestStats(statsReceiver: StatsReceiver) {
-    val requestCount = statsReceiver.stat("connection_requests")
+    val requestCount = statsReceiver.stat(Verbosity.Debug, "connection_requests")
   }
 }