finatra-thrift: Respect ThriftServer stack params in JavaRouter/Abstr…

…actThriftRouter

Problem

`JavaThriftRouter` ignores key Thrift params (such as protocolFactory, maxThriftBufferSize, etc)
configured via  `configureThriftServer`. This problem is partially worked around via accepting
protocolFactory along with the controller in `JavaThriftRouter.add`. The other Thrift params are
less fortunate.

Solution

Respect Thrift params configured on ThriftMux stack server in `JavaThriftRouter` and remove the
old `add(controller, protocolFactory)` method from the `JavaThriftRouter` API as it's now obsolete.

Results

There is now a single way of configuring Thrift-specific params for Finatra's Thrift servers that works
as expected in both, Java and Scala settings.

JIRA Issues: CSL-10136, CSL-10446

Differential Revision: https://phabricator.twitter.biz/D593876

finagle-thriftmux/src/main/scala/com/twitter/finagle/ThriftMux.scala

@@ -558,7 +558,7 @@ object ThriftMux
     def stack: Stack[ServiceFactory[mux.Request, mux.Response]] =
       muxer.stack
 
-    protected val serverParam: RichServerParam = RichServerParam(
+    protected[twitter] val serverParam: RichServerParam = RichServerParam(
       protocolFactory = params[Thrift.param.ProtocolFactory].protocolFactory,
       serviceName = params[Label].label,
       maxThriftBufferSize = params[Thrift.param.MaxReusableBufferSize].maxReusableBufferSize,