Skip to content

Commit

Permalink
finagle-core: specify how maxConcurrentRequests is applied
Browse files Browse the repository at this point in the history
Problem / Solution

maxConcurrentRequests's scaladoc doesn't specify whether the limit
is applied globally or per connection so let's specify it.

RB_ID=865732
  • Loading branch information
Daniel Schobel authored and jenkins committed Aug 26, 2016
1 parent 89bb7f8 commit e61c61c
Showing 1 changed file with 2 additions and 1 deletion.
Expand Up @@ -440,7 +440,8 @@ class ServerBuilder[Req, Rep, HasCodec, HasBindTo, HasName] private[builder](
* burst of traffic that exceeds this limit, the burst is rejected
* with a `Failure.Rejected` exception. Note, this failure signals
* a graceful rejection which is transmitted to clients by certain
* protocols in Finagle (e.g. Http, ThriftMux).
* protocols in Finagle (e.g. Http, ThriftMux). The limit is global
* to all sessions.
*
* To migrate to the Stack-based APIs, use `ServerAdmissionControlParams.concurrencyLimit`.
* For example:
Expand Down

0 comments on commit e61c61c

Please sign in to comment.