scrooge-generator: Remove ReqRepThriftServiceBuilder from struct.must…

…ache Problem: Scrooge is generating too much unused code. `ReqRepThriftServiceBuilder` has been deprecated since January 2018. Solution: Remove `ReqRepThriftServiceBuilder` from struct template. Result: Less scrooge-generated code. JIRA Issues: CSL-8564 Differential Revision: https://phabricator.twitter.biz/D345740
twitter · Jul 25, 2019 · f1c4d58 · f1c4d58
1 parent 464ae75
commit f1c4d58
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 13 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -15,6 +15,9 @@ Breaking API Changes
   of `GenSerialClientDispatcher` and `SerialClientDispatcher` have been removed.
   ``PHAB_ID=D342883``
 
+* finagle-thrift: The deprecated `ReqRepThriftServiceBuilder` object has been
+  removed. Users should migrate to `ReqRepMethodPerEndpointBuilder`. ``PHAB_ID=D345740``
+
 Runtime Behavior Changes
 ~~~~~~~~~~~~~~~~~~~~~~~~
 

diff --git a/...thrift/src/main/scala/com/twitter/finagle/thrift/service/ReqRepThriftServiceBuilder.scala b/...thrift/src/main/scala/com/twitter/finagle/thrift/service/ReqRepThriftServiceBuilder.scala