Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finagle Redis client auth command fails in 6.29.0 #422

Closed
mallman opened this issue Sep 30, 2015 · 5 comments
Closed

Finagle Redis client auth command fails in 6.29.0 #422

mallman opened this issue Sep 30, 2015 · 5 comments

Comments

@mallman
Copy link

mallman commented Sep 30, 2015

I have a working finagle-redis 6.28.0 client application that uses the redis AUTH command. When I upgraded to 6.29.0, the only change I made was to change this line of code:

val redisClient = Redis.newRichClient(address)

to

val redisClient = Redis.client.newRichClient(address)

(I presume this is the correct port. I cannot find user documentation on the new client API in 6.29.0.)

Immediately following, I call redisClient.auth(password). In 6.29.0, it barfs:

com.twitter.finagle.redis.ServerError: NOAUTH Authentication required.
    at com.twitter.finagle.redis.BaseClient$$anonfun$doRequest$1.applyOrElse(Client.scala:111) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.finagle.redis.BaseClient$$anonfun$doRequest$1.applyOrElse(Client.scala:110) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at scala.runtime.AbstractPartialFunction.apply(AbstractPartialFunction.scala:36) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.finagle.redis.Sets$$anonfun$sMembers$1.applyOrElse(SetCommands.scala:30) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.finagle.redis.Sets$$anonfun$sMembers$1.applyOrElse(SetCommands.scala:30) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at scala.PartialFunction$OrElse.apply(PartialFunction.scala:167) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Future$$anonfun$flatMap$1.apply(Future.scala:890) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Future$$anonfun$flatMap$1.apply(Future.scala:889) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise$Transformer.liftedTree1$1(Promise.scala:100) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise$Transformer.k(Promise.scala:100) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise$Transformer.apply(Promise.scala:110) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise$Transformer.apply(Promise.scala:91) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise$$anon$2.run(Promise.scala:358) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.concurrent.LocalScheduler$Activation.run(Scheduler.scala:193) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.concurrent.LocalScheduler$Activation.submit(Scheduler.scala:140) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.concurrent.LocalScheduler.submit(Scheduler.scala:222) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.concurrent.Scheduler$.submit(Scheduler.scala:84) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise.runq(Promise.scala:342) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise.updateIfEmpty(Promise.scala:713) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise.update(Promise.scala:686) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.util.Promise.setValue(Promise.scala:662) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.concurrent.AsyncQueue.offer(AsyncQueue.scala:88) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.finagle.netty3.transport.ChannelTransport.handleUpstream(ChannelTransport.scala:51) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:296) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.handler.codec.frame.FrameDecoder.unfoldAndFireMessageReceived(FrameDecoder.java:462) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.handler.codec.frame.FrameDecoder.callDecode(FrameDecoder.java:443) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.handler.codec.frame.FrameDecoder.messageReceived(FrameDecoder.java:303) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:70) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.SimpleChannelHandler.messageReceived(SimpleChannelHandler.java:142) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.finagle.netty3.channel.ChannelStatsHandler.messageReceived(ChannelStatsHandler.scala:78) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:88) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline$DefaultChannelHandlerContext.sendUpstream(DefaultChannelPipeline.java:791) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.SimpleChannelHandler.messageReceived(SimpleChannelHandler.java:142) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at com.twitter.finagle.netty3.channel.ChannelRequestStatsHandler.messageReceived(ChannelRequestStatsHandler.scala:35) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.SimpleChannelHandler.handleUpstream(SimpleChannelHandler.java:88) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:559) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:268) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.Channels.fireMessageReceived(Channels.java:255) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.socket.nio.NioWorker.read(NioWorker.java:88) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.socket.nio.AbstractNioWorker.process(AbstractNioWorker.java:108) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.socket.nio.AbstractNioSelector.run(AbstractNioSelector.java:337) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.socket.nio.AbstractNioWorker.run(AbstractNioWorker.java:89) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:178) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.util.ThreadRenamingRunnable.run(ThreadRenamingRunnable.java:108) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at org.jboss.netty.util.internal.DeadLockProofWorker$1.run(DeadLockProofWorker.java:42) ~[pacer-assembly-1.0-SNAPSHOT.jar:1.0-SNAPSHOT]
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) ~[?:1.8.0_60]
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) ~[?:1.8.0_60]
    at java.lang.Thread.run(Thread.java:745) ~[?:1.8.0_60]
@roanta
Copy link
Contributor

roanta commented Sep 30, 2015

Hey, sorry about the regression.

Can you try the following and let me know if it fixes your issue:

import com.twitter.finagle.loadbalancer.ConcurrentLoadBalancerFactory

val redisClient = Redis.client
   .configured(ConcurrentLoadBalancerFactory.Param(numConnections = 1))
   .newRichClient(address)

@mallman
Copy link
Author

mallman commented Sep 30, 2015

Hi @roanta,

Thanks for helping. I implemented the change you suggested, and my application works as expected. LMK if there's anything else I can do to help debug this issue.

Cheers.

@roanta
Copy link
Contributor

roanta commented Sep 30, 2015

Thanks! A silly mistake on our part. I'll push a patch through and it should be fixed in the next release.

@mallman
Copy link
Author

mallman commented Sep 30, 2015

Great! Thanks!

@vkostyukov
Copy link
Contributor

I belive it was fixed here so closing it. Thanks @mallman for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mallman @vkostyukov @roanta