New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to stop Netty 4 Timer #757
Comments
Ah. I suspect there may be other issues like this as haven't designed for that type of deployment model. This might require a patch to create a flag that allows you to opt-out of this behavior. |
Thanks for quick reply Kevin. In this case private object is used and I have no access to it. |
HashedWheelTimer... why are you using this? It is a cpu hog. Start up linkerd and namerd and they just sit their chewing anywhere from 1-3% cpu when nothing is happening... |
@mpnewcomb do you have any suggestions on how to improve it? if there is no work to do, it should be a thread that sleeps for a few milliseconds, looks for work, then repeats. |
Hello. This seems to work for me: |
Problem No possibility to stop "Netty 4 Timer". Detailed description is available here: [[ #757 | #757 ]] Solution Make HashedWheelTimer object public with additional method to stop "Netty 4 Timer" Result Possibility to stop "Netty 4 Timer" Signed-off-by: Jing Yan <jyan@twitter.com> GitOrigin-RevId: 290708fd02090af60d64462c8da5a0d5a2b94f99
Problem No possibility to stop "Netty 4 Timer". Detailed description is available here: [[ #757 | #757 ]] Solution Make HashedWheelTimer object public with additional method to stop "Netty 4 Timer" Result Possibility to stop "Netty 4 Timer" Signed-off-by: Jing Yan <jyan@twitter.com> Differential Revision: https://phabricator.twitter.biz/D381605
This feature to stop a Netty 4 Timer was added in fa4899e. Closing this issue now that it's resolved. |
Hello we are using Finagle as a HttpClient - it works really good. Great job.
Unfortunately Finagle generates resource leak under standard behavior that applications are deployed and undeployed many times on JBoss AS, Tomcat etc.
By resource leak I mean that if I 100 times deploy and undeploy an application that uses Finagle I'll get at least 100 threads
The problem is that finagle contains unstopable threads
eg.
The text was updated successfully, but these errors were encountered: