fingle-mysql: transaction support #368
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Currently it is not possible to run multiple statements using a single transaction. Solution Add the transactional method that executes a function within a transaction. The function's input is a client that has only one underlying database connection with an open transaction. The provided client instance must be used for all database interactions and never leak to outside the transactional block scope. The transaction is automatically committed in case of a success and automatically rolled back in case of a failure. Result Users are able to run multiple statements using a single transaction.
| @@ -33,6 +33,23 @@ object Client { | |||
| } | |||
| } | |||
|
|
|||
| def transactional[R](f: Client => Future[R]): Future[R] = | |||
| factory().flatMap { svc => | |||
| val client = apply(ServiceFactory.const(svc)) | |||
There was a problem hiding this comment.
As @mosesn mentioned, we recently added this internally and it's available as part of the develop branch.
Note though, this may have surprising results. Because of how the mysql client operates on the this ServiceFactory you aren't guaranteed exclusivity to this Service (i.e. connection in this case). You need to override the Service#close method to completely control its lifecycle. Take a look at how we implemented it in the develop branch.
|
I would say it's production ready; we have teams using it in production at twitter. What kind of difficulties have you guys run into? Is it mostly related to the bare API? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently it is not possible to run multiple statements using a
single transaction.
Solution
Add the
transactionalmethod that executes a function within a transaction.The function's input is a client that has only one underlying database
connection with an open transaction. The provided client instance
must be used for all database interactions and never leak to outside
the transactional block scope.
The transaction is automatically committed in case of a success and
automatically rolled back in case of a failure.
Result
Users are able to run multiple statements using a single transaction.