Fix 6.26.0 header level in CHANGES

[svetlyak40wt]

No description provided.

[mosesn]

[dschobel]

🚢

[taylorleese]

@dschobel Not to be confused with 🚢 🇮🇹 or 🐑 🇮🇹.

[svetlyak40wt]

Nice. Does somebody have rights to merge this pull request? :)

[svetlyak40wt]

Without this fix, allmychanges have problems which parsing changelog as reStructured file: https://allmychanges.com/p/scala/finagle/

[mosesn]

Wow, I had no idea allmychanges existed, very cool! Now that someone is actually consuming the rst, it would be neat to validate that it's right. It looks fine on the site you linked to, did you fix that manually? It's correct rst, right? It's just that it's not semantically correct.

[dschobel]

@svetlyak40wt unfortunately we're not set up to merge PRs directly via github, they have to go through twitter's internal repo which gets synced out every Monday.

details: https://github.com/twitter/finagle/blob/develop/CONTRIBUTING.md

[svetlyak40wt]

@mosesn allmychanges is my pet-project. Feel free to write me any time if you have some ideas related to it.

It has few parsers, markdown, rst, html and plain-text (which is able to handle most formats, but in a very restrictive way, for example, it will not handle rst or markdown links, etc). Right now I tuned this package to use plain-text parser for finagle, because rst parser returns 6.26.0 version with empty description.

Let me explain how it works. Markdown and rst files translate texts into html and then process it with html parser :)
Html parser searches h1, h2, h3, h4, h5 headers and if there is something like version number in the text of the header, then saves elements, following this header until a header of the same or higher level will be encountered.

Right now in the CHANGES 6.26.0 version's header is followed by "Deprecations" header of the same level. That causes the problem.

Plain text parser, works differently. It just looks at each line, and if it is relatively short and has a version number, then this line is considered a version number, and all next lines are saved as description until the next version number will be found.

That it.

[svetlyak40wt]

@dschobel so, I just have to wait for a Monday, right?

[dschobel]

@svetlyak40wt if it gets merged internally this week it'll show up in the develop branch on Monday so the only variable is the bandwidth of the team to pull it in (but we're usually good about clearing out all PRs that have passed review every week).

[svetlyak40wt]

Thank you, Daniel, thank you, Moses!

[vkostyukov]

I'm pulling this internally. Will close this PR once it's merged.

[svetlyak40wt]

@vkostyukov cool! Thank you!

[vkostyukov]

This has been merged internally (and will show up here very soon). Thanks @svetlyak40wt!