Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finagle-{core, http, redis, thrift}: Remove semicolons at end of lines #612

Closed
wants to merge 1 commit into from
Closed

finagle-{core, http, redis, thrift}: Remove semicolons at end of lines #612

wants to merge 1 commit into from

Conversation

zaneli
Copy link
Contributor

@zaneli zaneli commented Apr 28, 2017

Problem

The semicolon at the end of the line is unnecessary.

Solution

Removed semicolons.

@zaneli
finagle-{core, http, redis, thrift}: Remove semicolons at end of lines
c0ca4f1 
Problem

The semicolon at the end of the line is unnecessary.

Solution

Removed semicolons.
kevinoliver
kevinoliver approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@kevinoliver kevinoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thank you for the fixes!

@yufangong
Copy link
Contributor

@zaneli thanks for the fix, merged in 18ff67c

@yufangong yufangong closed this Apr 29, 2017
@zaneli zaneli deleted the remove-unnecessary-semicolon branch April 29, 2017 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinoliver kevinoliver kevinoliver approved these changes

Assignees
No one assigned
Labels
Ship It
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zaneli @yufangong @kevinoliver