Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support unsigned integer #618

Closed
wants to merge 13 commits into from
Closed

Support unsigned integer #618

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a08e174
Added unsigned int support to finagle-mysql
mehmetgunturkun May 11, 2017
ae2f56a
Added short description for attribute bit masks
mehmetgunturkun May 11, 2017
8fecffb
Added getCodeString to Type for debugging
mehmetgunturkun May 13, 2017
9d69d8e
Added unsigned support for all numerical integer field types
mehmetgunturkun May 13, 2017
e938863
Removed parenthesis from isSigned and isUnsigned since they do not mu…
mehmetgunturkun May 31, 2017
c4d1470
Removed readUnsignedLongBE and readUnsignedLongLE from MysqlBufReader
mehmetgunturkun May 31, 2017
27c385e
Merge branch 'develop' into Support_Unsigned_Integer
mehmetgunturkun May 31, 2017
aacf93b
Added ignoreUnsigned flag for Row
mehmetgunturkun Jul 8, 2017
1ed3e45
Removed println and wrote an insane comment for ignoreUnsigned
mehmetgunturkun Jul 10, 2017
d6aed81
Fixed CanBeParameter for BigInt to be sure that we always write 8 bytes.
mehmetgunturkun Jul 12, 2017
e219ad1
Introduced a named exception for too long BigInts.
mehmetgunturkun Jul 15, 2017
f296c6b
Merge branch 'develop' into Support_Unsigned_Integer
mehmetgunturkun Jul 17, 2017
5eb03e5
Reverse the order of byte array, big endian to little endian
mehmetgunturkun Jul 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 16 additions & 1 deletion finagle-mysql/src/main/scala/com/twitter/finagle/mysql/CanBeParameter.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,22 @@ object CanBeParameter {
new CanBeParameter[BigInt] {
def sizeOf(param: BigInt) = 8
def typeCode(param: BigInt) = Type.LongLong
def write(writer: MysqlBufWriter, param: BigInt) = writer.writeBytes(param.toByteArray)
def write(writer: MysqlBufWriter, param: BigInt) = {
val byteArray: Array[Byte] = param.toByteArray
val lengthOfByteArray: Int = byteArray.length

if (lengthOfByteArray > 8) {
throw new Exception(s"The length of BigInt is larger than 8 bytes: $lengthOfByteArray > 8")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you create a new named exception for this (can define it somehwere in the file here). I suggest something like:
class BigIntTooLongException(size: Int) extends Exception(s"BigInt is stored as an unsigned long and thus cannot be grater than 8 bytes. Size: $size"

}

for (i <- 0 until lengthOfByteArray) {
writer.writeByte(byteArray(i))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to reverse the order of the bytes we read out of byteArray: the BigInt.toByteArray method returns the bytes in big-endian order.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, sorry I should have checked that - sending the fix.

}

for (i <- lengthOfByteArray until 8) {
writer.writeByte(0x0)
}
}
}
}

Expand Down