finagle-redis: Redis cluster management #668
Conversation
Problem The current finagle-redis client does not have support for the CLUSTER commands introduced in Redis 3.0.0. Solution This adds support for a number of new cluster commands that are necessary to setup and manage a redis cluster. - CLUSTER ADDSLOT, assigns a storage slot to a server - CLUSTER SETSLOT, updates the state of a slot - CLUSTER SLOTS, returns a list of slots known to the server - CLUSTER GETKEYSINSLOT, returns keys stored in a slot - CLUSTER REPLICATE, changes a node to become a replica of a server - CLUSTER MEET, introduces cluster nodes to each other - CLUSTER NODES, returns the list of cluster nodes known to the server - CLUSTER INFO, returns the cluster specific info - MIGRATE, used to transfer keys to another node Result Using the introduced commands it is possible to setup a redis cluster for testing and live re-sharding. This is the first step in implementing the redis cluster client protocol. The next step is to handle operation redirects, i.e. when the server returns ASK or MOVED.
Codecov Report
@@ Coverage Diff @@
## develop #668 +/- ##
===========================================
- Coverage 71.73% 71.58% -0.15%
===========================================
Files 723 726 +3
Lines 23016 23110 +94
Branches 1812 1847 +35
===========================================
+ Hits 16511 16544 +33
- Misses 6505 6566 +61
Continue to review full report at Codecov.
|
|
Hi @mkhq, thanks for the pull request. I'll get someone who knows finagle-redis better than me to take a look soon. |
|
Sorry, my mistake. I now see the context from the other issue / pull request. I'm going to put this up for review internally and run against our existing internal code. Thanks. |
|
@ryanoneill thanks, sounds good 👍 Just a note on running the integration tests, the cluster protocol was introduced in Redis 3.2. I've tested it against Redis 4.x (and 3.x) and it worked fine. |
|
this would be useful to me. @ryanoneill any update on when Twitter can review? |
|
i think @ryanoneill got busy on some other work. we'll find someone else to take a look. thanks for your patience. |
it me. working on getting this pulled in, apologies for the delay and thanks for your patience. |
Problem
The current finagle-redis client does not have support for the CLUSTER commands introduced in Redis 3.0.0.
Solution
This adds support for a number of new cluster commands that are necessary to setup and manage a redis cluster.
Result
Using the introduced commands it is possible to setup a redis cluster for testing and live re-sharding. This is the first step in implementing the redis cluster client protocol. The next step is to handle operation redirects, i.e. when the server returns ASK or MOVED.