Skip to content

Commit

Permalink
pants: Rename {lib,}thrift-0.5.0 to {lib,}thrift
Browse files Browse the repository at this point in the history
Summary: Problem

When we change the version of thrift, we don't want to have to rename the lib,
which entails changing many BUILD files.

Solution

Since we only have one thrift, we can drop the version-specific suffix.

JIRA Issues: CSL-5593

TBR=true

NO_USER_HOOK=1

Differential Revision: https://phabricator.twitter.biz/D149423
  • Loading branch information
yufangong authored and jenkins committed Mar 22, 2018
1 parent ab44378 commit 12dcacf
Show file tree
Hide file tree
Showing 9 changed files with 10 additions and 10 deletions.
Expand Up @@ -4,7 +4,7 @@ java_library(
dependencies = [
"3rdparty/jvm/com/google/inject:guice",
"3rdparty/jvm/javax/inject:javax.inject",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/slf4j:slf4j-api",
"finagle/finagle-core/src/main/scala",
"finagle/finagle-http/src/main/scala",
Expand Down
Expand Up @@ -5,7 +5,7 @@ junit_tests(
"3rdparty/jvm/com/google/guava",
"3rdparty/jvm/com/google/inject:guice",
"3rdparty/jvm/junit",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scalatest",
"3rdparty/jvm/org/slf4j:slf4j-api",
"3rdparty/jvm/org/slf4j:slf4j-simple",
Expand Down
2 changes: 1 addition & 1 deletion http/src/main/scala/BUILD
Expand Up @@ -24,7 +24,7 @@ scala_library(
"3rdparty/jvm/io/netty",
"3rdparty/jvm/javax/inject:javax.inject",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scala-lang/modules:scala-parser-combinators",
"3rdparty/jvm/org/slf4j:jcl-over-slf4j",
"3rdparty/jvm/org/slf4j:jul-to-slf4j",
Expand Down
2 changes: 1 addition & 1 deletion http/src/test/scala/BUILD
Expand Up @@ -23,7 +23,7 @@ junit_tests(
"3rdparty/jvm/javax/inject:javax.inject",
"3rdparty/jvm/joda-time",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scala-lang/modules:scala-xml",
"3rdparty/jvm/org/scalatest",
"3rdparty/jvm/org/slf4j:slf4j-api",
Expand Down
4 changes: 2 additions & 2 deletions inject/inject-server/src/test/scala/BUILD
Expand Up @@ -12,7 +12,7 @@ junit_tests(
"3rdparty/jvm/com/google/inject/extensions:guice-testlib",
"3rdparty/jvm/commons-lang",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scala-lang/modules:scala-parser-combinators",
"3rdparty/jvm/org/scalatest",
"3rdparty/jvm/org/slf4j:slf4j-api",
Expand Down Expand Up @@ -53,7 +53,7 @@ scala_library(
"3rdparty/jvm/com/google/inject/extensions:guice-testlib",
"3rdparty/jvm/commons-lang",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scalatest",
"3rdparty/jvm/org/slf4j:slf4j-api",
"3rdparty/jvm/org/specs2",
Expand Down
2 changes: 1 addition & 1 deletion jackson/src/main/scala/BUILD
Expand Up @@ -25,7 +25,7 @@ scala_library(
"3rdparty/jvm/javax/inject:javax.inject",
"3rdparty/jvm/joda-time",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scala-lang:scala-compiler",
"3rdparty/jvm/org/scala-lang:scalap",
"3rdparty/jvm/org/slf4j:slf4j-api",
Expand Down
2 changes: 1 addition & 1 deletion jackson/src/test/scala/BUILD
Expand Up @@ -21,7 +21,7 @@ junit_tests(
"3rdparty/jvm/joda-time",
"3rdparty/jvm/junit",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/mockito:mockito-all",
"3rdparty/jvm/org/scalacheck",
"3rdparty/jvm/org/scalatest",
Expand Down
2 changes: 1 addition & 1 deletion thrift/src/main/scala/BUILD
Expand Up @@ -15,7 +15,7 @@ scala_library(
"3rdparty/jvm/javax/inject:javax.inject",
"3rdparty/jvm/joda-time",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/slf4j:jcl-over-slf4j",
"3rdparty/jvm/org/slf4j:jul-to-slf4j",
"3rdparty/jvm/org/slf4j:log4j-over-slf4j",
Expand Down
2 changes: 1 addition & 1 deletion thrift/src/test/java/BUILD
Expand Up @@ -11,7 +11,7 @@ junit_tests(
"3rdparty/jvm/com/google/inject/extensions:guice-testlib",
"3rdparty/jvm/javax/inject:javax.inject",
"3rdparty/jvm/net/codingwell:scala-guice",
"3rdparty/jvm/org/apache/thrift:libthrift-0.5.0",
"3rdparty/jvm/org/apache/thrift:libthrift",
"3rdparty/jvm/org/scalatest",
"3rdparty/jvm/org/slf4j:slf4j-api",
"finagle/finagle-core/src/main/scala",
Expand Down

0 comments on commit 12dcacf

Please sign in to comment.