Skip to content

Commit

Permalink
finagle-core: Move PanicMode out of LoadBalancerFactory and document …
Browse files Browse the repository at this point in the history
…Panic Mode

Problem:
The `PanicMode` class is inside LoadBalancerFactory, which is hard to access.

We don't have docs in the Finagle clients section about panic mode.

Solution:
Move `PanicMode` class from
`com.twitter.finagle.loadbalancer.LoadBalancerFactory` to
`com.twitter.finagle.loadbalancer.PanicMode`.

Introduce the API `.withLoadBalancer.panicMode` to set the panic mode. Add docs
in the Finagle user guide client section.

JIRA Issues: CSL-10897

Differential Revision: https://phabricator.twitter.biz/D879034
  • Loading branch information
tigerlily-he authored and jenkins committed Apr 23, 2022
1 parent 0aca812 commit 2894466
Showing 1 changed file with 0 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ package com.twitter.finagle.loadbalancer
import com.twitter.finagle.Address.Inet
import com.twitter.finagle._
import com.twitter.finagle.context.Contexts
import com.twitter.finagle.loadbalancer.LoadBalancerFactory.PanicMode
import com.twitter.finagle.partitioning.zk.ZkMetadata
import com.twitter.finagle.stats.StatsReceiver
import com.twitter.finatra.streams.queryable.thrift.domain.RequestedShardIds
Expand Down

0 comments on commit 2894466

Please sign in to comment.