Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
finatra: Properly log bound address in server startup
Problem The http server doesn't properly log the bound address of the started listening server such that when the ephemeral port (0) is used, the logged output still shows the server bound to port 0. Solution Ensure we log the bound address of the server and make thrift server logging (which was logging the raw InetSocketAddress) to be the same. Result: Thrift before: [main] INFO com.twitter.echo.thrift.EchoThriftServerMain$ - thrift server started on port: /0:0:0:0:0:0:0:0:50058 Thrift after: [main] INFO com.twitter.echo.thrift.EchoThriftServerMain$ - admin http server started on port 50058 Http before: [main] INFO com.twitter.echo.http.EchoHttpServerMain$ - http server started on port: 0.0.0.0/0.0.0.0:50084 [main] INFO com.twitter.echo.http.EchoHttpServerMain$ - http server started on port: 0.0.0.0/0.0.0.0:0 (when using the emphermal port) Http after: [main] INFO com.twitter.echo.http.EchoHttpServerMain$ - http server started on port 50084 Differential Revision: https://phabricator.twitter.biz/D563758
- Loading branch information