Skip to content

Commit

Permalink
finatra: Bazelify
Browse files Browse the repository at this point in the history
Problem / Solution

We're cutting over to bazel, so pants commands won't work in the future.
We should update comments and scripts to use bazel instead.

JIRA Issues: CSL-12145

Differential Revision: https://phabricator.twitter.biz/D930039
  • Loading branch information
mosesn authored and jenkins committed Jul 12, 2022
1 parent e59f0a8 commit 457bf19
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 55 deletions.
2 changes: 1 addition & 1 deletion PROJECT.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# See go/project-docs. Generated using ./pants run src/python/twitter/phabricator:owners_to_project -- --dirs=a/owned/path,b/owned/path
# See go/project-docs. Generated using ./bazel run src/python/twitter/phabricator:owners_to_project -- --dirs=a/owned/path,b/owned/path

owners:
- banderson
Expand Down
28 changes: 0 additions & 28 deletions examples/scripts/run.sh

This file was deleted.

20 changes: 0 additions & 20 deletions examples/scripts/test.sh

This file was deleted.

4 changes: 2 additions & 2 deletions inject/inject-request-scope/src/main/java/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ java_library(
],
)

# TODO: Remove this and references to it,
# when a fix for https://github.com/pantsbuild/pants/issues/7200 has landed.
# TODO: Change this to filegroup per https://github.com/pantsbuild/pants/issues/7200
# when we switch entirely to bazel
files(
name = "pants-workaround",
sources = ["**/*.java"],
Expand Down
4 changes: 2 additions & 2 deletions inject/inject-thrift-client/src/main/java/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ java_library(
],
)

# TODO: Remove this and references to it,
# when a fix for https://github.com/pantsbuild/pants/issues/7200 has landed.
# TODO: Change this to filegroup per https://github.com/pantsbuild/pants/issues/7200
# when we switch entirely to bazel
files(
name = "pants-workaround",
sources = ["**/*.java"],
Expand Down
4 changes: 2 additions & 2 deletions validation/src/main/java/com/twitter/finatra/validation/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ java_library(
],
)

# TODO: Remove this and references to it,
# when a fix for https://github.com/pantsbuild/pants/issues/7200 has landed.
# TODO: Change this to filegroup per https://github.com/pantsbuild/pants/issues/7200
# when we switch entirely to bazel
files(
name = "pants-workaround",
sources = ["*.java"],
Expand Down

0 comments on commit 457bf19

Please sign in to comment.