inject-modules: Delete c.t.inject.modules.LoggerModule

Problem

The c.t.inject.modules.LoggerModule is deprecated as it
does not provide a solution inline with the best practices
for bridging JUL to the SLF4J-API.

Solution

Delete the deprecated code.

Result

Less tech-debt.

what

Differential Revision: https://phabricator.twitter.biz/D853325

CHANGELOG.rst

@@ -10,6 +10,8 @@ Unreleased
 Changed
 ~~~~~~~
 
+* inject-modules: Remove deprecated `c.t.inject.modules.LoggerModule`. ``PHAB_ID=D853325``
+
 * finatra: Bump version of Jackson to 2.13.2 ``PHAB_ID=D848592``
 
 * inject-thrift-client: Deprecate `c.t.inject.thrift.AndThenService`, `c.t.inject.thrift.modules.AndThenServiceModule`, 
@@ -29,8 +31,8 @@ Changed
   log messages emitted to JUL before where the bridging would have been attempted when using
   the `LoggerModule`.
 
-  Note that `Slf4jBridge` trait is already mixed into the `c.t.server.TwitterServer` trait and
-  thus no further action is necessary forbridging JUL to the SLF4J-API in extensions of
+  Note that the `Slf4jBridge` trait is already mixed into the `c.t.server.TwitterServer` trait and
+  thus no further action is necessary for bridging JUL to the SLF4J-API in extensions of
   `c.t.server.TwitterServer`. ``PHAB_ID=D827584``
 
 * inject-slf4j: Deprecate `c.t.inject.logging.Logging` trait and methods. Users are encouraged
@@ -43,6 +45,7 @@ Changed
 
 Added
 ~~~~~
+
 * http-server: (BREAKING API CHANGE) Allow for customization of the building of the HTTP and HTTPS
   `ListeningServer` constructs. This allows users to specify any additional configuration over the
   Finagle `Service[-R, +R]` that is constructed by the `HttpRouter`. The

build.sbt

@@ -448,7 +448,6 @@ lazy val injectModules = (project in file("inject/inject-modules"))
     moduleName := "inject-modules",
     libraryDependencies ++= Seq(
       "com.twitter" %% "finagle-core" % versions.twLibVersion,
-      "com.twitter" %% "util-slf4j-jul-bridge" % versions.twLibVersion,
       "com.twitter" %% "util-stats" % versions.twLibVersion,
       "org.slf4j" % "slf4j-simple" % versions.slf4j % "test-internal"
     ),

inject/inject-modules/src/main/scala/com/twitter/inject/modules/BUILD

@@ -13,8 +13,6 @@ scala_library(
         "finatra/inject/inject-core/src/main/scala/com/twitter/inject",
         "finatra/inject/inject-modules/src/main/scala/com/twitter/inject/modules/internal",
         "finatra/inject/inject-stack/src/main/scala/com/twitter/inject",
-        "util/util-slf4j-api/src/main/scala/com/twitter/util/logging",
-        "util/util-slf4j-jul-bridge/src/main/scala",
         "util/util-stats/src/main/scala/com/twitter/finagle/stats",
     ],
 )