Skip to content

Commit

Permalink
inject-thrift-client: Deprecate AndThenService and module
Browse files Browse the repository at this point in the history
Problem

The `AndThenService` was a component to the original Finatra record/replay
functionality that was never moved out of experimental. This code does
nothing.

Solution

Deprecate with an intention to remove.

Differential Revision: https://phabricator.twitter.biz/D845841
  • Loading branch information
cacoco authored and jenkins committed Mar 7, 2022
1 parent b0b273d commit 887c2ff
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 5 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.rst
Expand Up @@ -7,6 +7,14 @@ Note that ``RB_ID=#`` and ``PHAB_ID=#`` correspond to associated message in comm
Unreleased
----------

Changed
~~~~~~~

* inject-thrift-client: Deprecate `c.t.inject.thrift.AndThenService`, `c.t.inject.thrift.modules.AndThenServiceModule`,
and `c.t.inject.thrift.internal.DefaultAndThenServiceImpl`. These were plumbing for unreleased
experimental record/replay functionality and currently do nothing with no plan for implementation.
``PHAB_ID=D845841``

22.2.0
------

Expand Down
@@ -1,8 +1,11 @@
package com.twitter.inject.thrift

import com.twitter.finagle.{Filter, Service}
import com.twitter.scrooge.{ThriftMethod, ThriftStruct}
import com.twitter.finagle.Filter
import com.twitter.finagle.Service
import com.twitter.scrooge.ThriftMethod
import com.twitter.scrooge.ThriftStruct

@deprecated("No replacement.", "2022-03-03")
trait AndThenService {
def andThen[Req <: ThriftStruct, Rep](
method: ThriftMethod,
Expand Down
@@ -1,9 +1,12 @@
package com.twitter.inject.thrift.internal

import com.twitter.finagle.{Filter, Service}
import com.twitter.finagle.Filter
import com.twitter.finagle.Service
import com.twitter.inject.thrift.AndThenService
import com.twitter.scrooge.{ThriftMethod, ThriftStruct}
import com.twitter.scrooge.ThriftMethod
import com.twitter.scrooge.ThriftStruct

@deprecated("No replacement.", "2022-03-03")
private[thrift] class DefaultAndThenServiceImpl extends AndThenService {
def andThen[Req <: ThriftStruct, Rep](
method: ThriftMethod,
Expand Down
Expand Up @@ -4,9 +4,10 @@ import com.twitter.inject.TwitterModule
import com.twitter.inject.thrift.AndThenService
import com.twitter.inject.thrift.internal.DefaultAndThenServiceImpl

@deprecated("No replacement.", "2022-03-03")
object AndThenServiceModule extends TwitterModule {

override def configure: Unit = {
override def configure(): Unit = {
bind[AndThenService].to[DefaultAndThenServiceImpl]
}

Expand Down

0 comments on commit 887c2ff

Please sign in to comment.