inject-server: correctly wire through method in AdminHttpClient

Problem

The HTTP method is not passed into `createApiRequest`,
causing all requests to use the default GET method.
This prevents calling the admin endpoint with the POST method.

Solution

Pass the method parameter in.

Differential Revision: https://phabricator.twitter.biz/D584988

CHANGELOG.rst

@@ -53,6 +53,12 @@ Changed
   producers/consumers. Producer tracing is turned on by default and consumer tracing is turned off
   by default now. ``PHAB_ID=D571064``
 
+Fixed
+~~~~~~~
+
+* inject-server: Wire through HTTP method in AdminHttpClient so that POST requests can be made to
+  HTTPAdmin endpoints. ``PHAB_ID=D584988``
+
 20.10.0
 -------
 

inject/inject-server/src/test/scala/com/twitter/inject/server/AdminHttpClient.scala

@@ -79,7 +79,7 @@ private[twitter] abstract class AdminHttpClient private[twitter] (
     method: Method
   ): Response = {
 
-    val request = createApiRequest(path)
+    val request = createApiRequest(path, method)
     httpAdminClient(
       request,
       addAcceptHeader(accept, headers),

inject/inject-server/src/test/scala/com/twitter/inject/server/tests/EmbeddedTwitterServerIntegrationTest.scala

@@ -435,6 +435,17 @@ class EmbeddedTwitterServerIntegrationTest extends Test {
     }
   }
 
+  test("server#httpPostAdmin sends a valid POST request") {
+    val embeddedServer = new EmbeddedTwitterServer(
+      twitterServer = new TwitterServer {},
+    )
+    try {
+      embeddedServer.httpPostAdmin("/quitquitquit", andExpect = Status.Ok, withBody = "quitting\n")
+    } finally {
+      embeddedServer.close()
+    }
+  }
+
   /* utility method tests */
 
   test("method#reduceScopedFunction") {