path definitions on routes

[grandbora]

• Adds path definitions to routes
• Refactors findRouteAndMatch method

Use case is; on controller error handler (definition, usage) we want to log which endpoint is failed. One easy way to do that is to log the request path, but most of the paths we use have dynamic values (id, tag etc.). Therefore when we log the request path, we are having trouble when aggregating the log output for monitoring purposes. So instead of request path what we need is the route that is matched.
The closest I could get was getting the PathPattern from router as shown below;

val pathPattern = finatraController.route.findRouteAndMatch(request, request.getMethod).get._2.toString

Unfortunately PathPattern is not user friendly and doesn’t look good on graphs(eg PathPattern(^/users/([^/?#]+)/xx/yy$,List(user))). Therefore I added the the string path definition(eg) to the routes of the controller. So with the same code above we can get the human readable definition of the route that is matched.

PS. this is a pain point for me, would be happy if you can either merge/release or suggest an alternative.
PS. also slightly refactored the method that does the matching.
PS. router does not have a spec.

[grandbora]

Shame that this did not go in with 1.5.3 release.

[capotej]

I know! It came in right after we had submitted to maven central. It'll go
out in a week or two.

On Wed, Apr 16, 2014 at 10:14 AM, Bora Tunca notifications@github.comwrote:

Shame that this did not go in with 1.5.3 release.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/131?utm_campaign=website&utm_source=sendgrid.com&utm_medium=email#issuecomment-40625900
.

Julio Capote

[grandbora]

Ok, thanks

[grandbora]

Is it possible to merge this, before I forgot about this pr and force push to branch again :)

[grandbora]

Feels like this won't be merged in, closing it.

[capotej]

Hey, sorry about this, got lost in email. Please reopen and I'll merge. Thanks!

[grandbora]

No worries, thanks for merging.