Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to twitter-server 1.8.0 (finagle 6.22.0) #176

Merged
merged 2 commits into from Nov 7, 2014

Conversation

@bpfoster
Copy link
Contributor

commented Oct 31, 2014

No description provided.

@twoism

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2014

Looks like the update breaks CI.

@bpfoster

This comment has been minimized.

Copy link
Contributor Author

commented Nov 2, 2014

Fixed the logging spec. Looks like the handling of flags changed and value was cached. I believe this still validates the same test case, let me know if not.

@michiroth

This comment has been minimized.

Copy link

commented Nov 6, 2014

Merge merge merge :)

capotej added a commit that referenced this pull request Nov 7, 2014

Merge pull request #176 from bpfoster/twitter-server-1.8.0
Update to twitter-server 1.8.0 (finagle 6.22.0)

@capotej capotej merged commit 0b9fce0 into twitter:master Nov 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@michiroth

This comment has been minimized.

Copy link

commented Nov 10, 2014

Yes, many thanks!

@bpfoster bpfoster deleted the bpfoster:twitter-server-1.8.0 branch Nov 10, 2014

cacoco pushed a commit that referenced this pull request May 13, 2015

Merge pull request #176 from bpfoster/twitter-server-1.8.0
Update to twitter-server 1.8.0 (finagle 6.22.0)

cacoco pushed a commit that referenced this pull request May 14, 2015

Merge pull request #176 from bpfoster/twitter-server-1.8.0
Update to twitter-server 1.8.0 (finagle 6.22.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.