This repository has been archived by the owner on Apr 7, 2022. It is now read-only.
Module for Twitter4J v3 support #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like twitter4j added another callback to SiteStreamListener: It's not in the other listeners though |
|
Any reason we don't want to just merge this into the twitter4j module and bump the major version to 2.0? Doesn't seem ideal to maintain two different modules for two different versions of twitter4j unless I'm missing something. |
|
@caniszczyk i plan to remove the other module after the streaming api removes support. |
* move example over to using t4j v3
|
@xsl good catches. I've added the callbacks and updated the t4j example code to use v3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #50.
More or less a copy-paste of the existing module. I moved the code into com.twitter.hbc.twitter4j.v3 to keep it separate, and also seems nice if we need to support future versions.
Looks like t4j v3 removed support on UserStreamListener for onRetweet so that had to get moved into our UserstreamHandler class.