Successful Rsc-based compilation of a case study project #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lays the groundwork for fixing twitter#239, but unfortunately eager loading of dependency classpaths is insanely slow (benchMjar goes up from 310ms to 1548ms which makes this solution unacceptable).
… inner Java classes (see twitter#239) This fixes the corresponding ticket, but unfortunately eager loading of dependency classpaths is insanely slow (benchMjar goes up from 310ms to 1548ms which makes this solution unacceptable).
…o static inner Java classes (see twitter#239)" This reverts commit e91546a.
This reverts commit 1834b78.
This aligns Rsc results with Scalac results. Instead of producing a standalone .semanticdb file, Rsc now produces a more appropriate META-INF/semanticdb/combined.semanticdb.
… inner Java classes (fix twitter#239) Unlike e91546a, this fix has acceptable performance characteristics (benchScalasig goes up from 322.939ms to 342.001ms).
The former is inconsistent with our singular style for package names.
Scalasigs are also stored in classes, so I decided to emphasize the fact that this checker compares not just metadata but also bytecode.
benchSemanticdb increases from 165ms to 179ms, benchMjar decreases from 342ms to 282ms.
When compiling into a jar, benchSemanticdb decreases from 179ms to 175ms. When compiling into a dir, benchSemanticdb increases from 165ms to 194ms.
benchSemanticdb decreases from 175ms to 169ms (basically, to the times when we were writing combined.semanticdb via DirectoryOutput), benchMjar decreases from 278ms to 263ms.
This was referenced Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.