Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use the latest scala versions #1719

Merged
merged 2 commits into from
Sep 24, 2017
Merged

use the latest scala versions #1719

merged 2 commits into from
Sep 24, 2017

Conversation

johnynek
Copy link
Collaborator

We have some pretty old versions of scala being used here.

@johnynek
Copy link
Collaborator Author

review @ttim @piyushnarang @ianoc ?

@piyushnarang
Copy link
Collaborator

Seems like the repl build is failing on 2.12.3:

[error] /home/travis/build/twitter/scalding/scalding-repl/src/main/scala/com/twitter/scalding/ScaldingILoop.scala:117: value appendToValue is not a member of s.MultiStringSetting
[error]             s.loadfiles.appendToValue(f.toString)
[error]                         ^
[error] one error found

@johnynek
Copy link
Collaborator Author

how does this look now @piyushnarang ?

@ianoc
Copy link
Collaborator

ianoc commented Sep 24, 2017

lgtm

@johnynek johnynek merged commit 1d69d8e into develop Sep 24, 2017
@piyushnarang
Copy link
Collaborator

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ttim ttim

@piyushnarang piyushnarang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnynek @piyushnarang @ianoc @ttim