Adding a test for the scalding repl

[sriramkrishnan]

Also includes some refactoring of the shell scripts to avoid duplication of code.

[johnynek]

Nice. @ianoc is the local bash-master. I am not competent to review this. Glad to have the tests.

[hougs]

The returned exit code is actually still 127, as set in the commons script.

[sriramkrishnan]

Maybe the comment wasn't clear. But "diff tutorial/data/hello.txt tutorial/data/output1.txt" exits with a non-zero exit code, and hence the test_tutorials.sh fails will fail (due to the set -e). Which is what we want. I will clarify the comment.

[hougs]

I think this test looks great, thanks for adding it. The code that you factored into the script commons is useful for the repl, because otherwise it doesn't exit correctly when you try to quit it. I'm not sure what the use is in the test script. I would recommend getting rid of that if it doesn't have a purpose. You shouldn't need it to run the repl from a user's POV. I think it actually just makes it harder to understand what is failing and where, because of the rigamaroll w exit statuses.
Thanks for the good work!

[sriramkrishnan]

If I don't use the common code, running the test_tutorials.sh from the command-line makes you lose your stty settings. And it is reasonable to expect that one would want to run the test tutorials script from the command-line (e.g. when developing locally). So I wanted to make sure that we have the same code there. I factored it out so I didn't have to duplicate the same code. But yeah, refactoring bash code and preserving exit statuses doesn't necessarily make it easier to read. In this case, we just want to exit with a non-zero exit status though if any of the tutorials fails.

[ianoc]

dirname $0 can fail to identify the current working path for the distro under relative paths or other things... we should use

DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"

for it, its about the most reliable way to get the info

[sriramkrishnan]

Will do. Updated PR coming.

[sriramkrishnan]

So @ianoc, any more comments? Can this be merged? Thanks!

[sriramkrishnan]

Thanks all!