Skip to content

Commit

Permalink
scrooge: Add maxThriftBuffer parameter for inherited services
Browse files Browse the repository at this point in the history
Followup to "scrooge: Reduce allocations in generated code" (RB_ID=628710)

Problem

Thrift services that extend other services do not pass in the maxThriftBufferSize param and the StatsReceiver, so default values are used.

Solution

Add new parameters to the parent constructor.

RB_ID=639844
  • Loading branch information
nshkrob authored and jenkins committed Apr 22, 2015
1 parent 12366f4 commit 2747ed5
Showing 1 changed file with 1 addition and 1 deletion.
Expand Up @@ -22,7 +22,7 @@ class {{ServiceName}}$FinagleService(
protocolFactory: TProtocolFactory,
stats: StatsReceiver,
maxThriftBufferSize: Int
) extends {{finagleServiceParent}}{{#hasParent}}(iface, protocolFactory){{/hasParent}} {
) extends {{finagleServiceParent}}{{#hasParent}}(iface, protocolFactory, stats, maxThriftBufferSize){{/hasParent}} {
import {{ServiceName}}._

def this(
Expand Down

0 comments on commit 2747ed5

Please sign in to comment.