Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard use of BinaryProtocol.setReadLength #203

Closed
codefromthecrypt opened this issue Aug 31, 2015 · 2 comments
Closed

Guard use of BinaryProtocol.setReadLength #203

codefromthecrypt opened this issue Aug 31, 2015 · 2 comments
Labels
good first issue

Comments

@codefromthecrypt
Copy link

Via 018aef8, scrooge started using TBinaryProtocol.setReadLength about 2 weeks ago.

This pins the maximum libthrift version to 0.9.0 as TBinaryProtocol.setReadLength was removed starting in 0.9.1.
apache/thrift@2ca9c20

Can this be implemented in a way that's compatible with versions beyond 0.9.0? Here's an example https://issues.apache.org/jira/browse/PARQUET-180
codefromthecrypt pushed a commit to openzipkin/zipkin that referenced this issue Aug 31, 2015
Updates dependencies, particularly to thrift 0.9.0
41b8ca1 
thrift 0.9.0 as opposed to 0.9.2 as scrooge uses a method that has been
removed.

See twitter/scrooge#203
@kevinoliver
Copy link
Contributor

that seems like a reasonable way to patch it.

@yufangong
Copy link
Contributor

Thanks, @adriancole. We have removed TBinaryProtocol.setReadLength usage in 997f246. Closing this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Milestone
No milestone
Development

No branches or pull requests
4 participants
@codefromthecrypt @mosesn @kevinoliver @yufangong