Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macro to the list of ScalaKeywords #276

Closed
wants to merge 1 commit into from

Conversation

avibryant
Copy link
Contributor

The identifier macro is now a keyword in Scala. This adds it to the list of ScalaKeywords so that it gets escaped properly by Scrooge.

Copy link
Contributor

@kevinoliver kevinoliver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @avibryant

@codecov-io
Copy link

codecov-io commented Sep 11, 2017

Codecov Report

Merging #276 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #276   +/-   ##
========================================
  Coverage    45.41%   45.41%           
========================================
  Files           73       73           
  Lines         3312     3312           
  Branches       215      221    +6     
========================================
  Hits          1504     1504           
  Misses        1808     1808
Impacted Files Coverage Δ
...a/com/twitter/scrooge/backend/ScalaGenerator.scala 46.98% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bdf36c...6c2d819. Read the comment docs.

@kevinoliver
Copy link
Contributor

this got merged in 3251125

thanks again, @avibryant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants