Fix the stats reporting for the java scrooge thrift code generation #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which throws java errors upon a client instantiation. The order of operations makes the stats object initialize before the statsReceiver is assigned.
|
is there an update for this pull request? |
|
ping @chunyan |
|
@chunyan any chance this can be merged soon since the java code generation has been broken (runtime, not compile time) for a while? |
chunyan
pushed a commit
that referenced
this pull request
Feb 11, 2013
Fix the stats reporting for the java scrooge thrift code generation
|
Sorry for the delay! Thanks much for the fix, @ddispaltro |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Java client code throws an NPE upon a client instantiation. The order of operations makes the stats object initialize before the statsReceiver is assigned. This makes it a lazy function instead.
UPDATE: This is particularly target
3.0.3(which I had to build myself) but the same pattern is in3.0.1