Standard header only #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bemurphy this rips out a lot of your code. The separation really helped :) |
|
whoa time machine. @oreoshake cool glad it helped! |
added 2 commits
November 4, 2013 16:08
|
|
||
| # you can also use lambdas to use dynamically generated nonces | ||
| :script_nonce => lambda { @script_nonce] = 'something' } | ||
| :script_nonce => lambda { @script_nonce] = 'something' } |
There was a problem hiding this comment.
This seems like a typo... What's with the ']' just hanging there?
|
I support ripping out brwsr and just sending more headers... Honestly, I send most of these via Apache or nginx rules anyway. |
|
Looks good to me but I'm not really an expert. |
This was referenced Nov 11, 2013
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rips out all browser-specific CSP handling and only serves the standard header.
A followup: I'd like to rip out the brwsr gem and not do any UA sniffing. This will mean more headers are sent...
Fixes #73