This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Moves shared code out of core/storm to the online package for use with o... #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h other planners/more general purpose code
| "com.twitter" %% "storehaus-core" % storehausVersion, | ||
| "com.twitter" %% "chill" % chillVersion, | ||
| "com.twitter" %% "storehaus-algebra" % storehausVersion, | ||
| withCross("com.twitter" %% "util-core" % utilVersion) |
There was a problem hiding this comment.
I don't think this is needed, and we may be screwing up if we are not careful. We could dave duplicated classes.
There was a problem hiding this comment.
the with cross isn't needed? The other usage(storm) uses it like this, so it won't make things 'worse' anyway I don't think?
There was a problem hiding this comment.
I think withCross IS needed, because util isn't published for scala 2.9.3. You won't be able to build without it, I don't think.
There was a problem hiding this comment.
It is, i just checked, no 2.9.3 util-core published :/
There was a problem hiding this comment.
cool. Just want to make sure we keep that right. Using withCross should be consistent in out stack. Thanks for checking.
johnynek
added a commit
that referenced
this pull request
Oct 15, 2013
Moves shared code out of core/storm to the online package for use with o...
snoble
pushed a commit
to snoble/summingbird
that referenced
this pull request
Sep 8, 2017
Optimize HLL sumOption
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ther planners/more general purpose code
Move non-specific storm code out of the storm project