This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
Avoid deprecated com.twitter.conversions #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apologies for not compiling first. New patch coming that avoids conversions entirely. |
ttim
pushed a commit
that referenced
this pull request
Feb 11, 2019
Problem As noted in #774 Twitter util deprecated some conversions. However, summingbird is on an older version of util that does not have the new APIs. Solution Avoid the conversions sugar completely.
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
Apr 22, 2019
Problem Twitter's util deprecated `com.twitter.conversions.time` in [twitter/util@c4c33a3](twitter/util@c4c33a3). Solution Use `com.twitter.conversions.DurationOps`.
ttim
pushed a commit
to ttim/summingbird
that referenced
this pull request
Apr 22, 2019
Problem As noted in twitter#774 Twitter util deprecated some conversions. However, summingbird is on an older version of util that does not have the new APIs. Solution Avoid the conversions sugar completely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Twitter's util deprecated
com.twitter.conversions.timein twitter/util@c4c33a3.Solution
Use
com.twitter.conversions.DurationOps.