Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #155

Open
elfring opened this issue Oct 25, 2013 · 1 comment
Open

reserved identifier violation #155

elfring opened this issue Oct 25, 2013 · 1 comment

Comments

@elfring
Copy link

elfring commented Oct 25, 2013

I would like to point out that identifiers like "_NC_CONNECTION_H_" and "_NC_MESSAGE_H_" do not fit to the expected naming convention of the C language standard.
Would you like to adjust your selection for unique names?
@manjuraj
Copy link
Collaborator

happy to change it if you send me pull request

elfring added a commit to elfring/twemproxy that referenced this issue Dec 31, 2013
@elfring
Bug twitter#155: Include guards became unique.
6f0d803 
Some include guards did not fit to the expected naming convention of the C language standard.
This detail was fixed by the deletion of leading underscores.

The probability for name clashes was also reduced by the addition of a kind of
universally unique identifier as a suffix.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
@elfring elfring mentioned this issue Dec 31, 2013
Open
@elfring elfring mentioned this issue May 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manjuraj @elfring