Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #134

Closed
elfring opened this issue May 21, 2015 · 4 comments
Closed

reserved identifier violation #134

elfring opened this issue May 21, 2015 · 4 comments

Comments

@elfring
Copy link

elfring commented May 21, 2015

I would like to point out that identifiers like "_DYN_CORE_H_" and "_DYN_SETTING_H_" do not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@timiblossom
Copy link
Contributor

What do you suggest? This is C project, not C++, and we inherited those from twemproxy's naming convention.

@elfring
Copy link
Author

elfring commented May 23, 2015

Would you like to reuse anything from updates for a similar issue in some other software?

How do you think about to make your include guards not only standard-compliant but also really unique by appending a kind of UUID?

@smukil
Copy link
Contributor

smukil commented Apr 30, 2019

Closing since dated.

@smukil smukil closed this as completed Apr 30, 2019
@elfring
Copy link
Author

elfring commented May 1, 2019

How do you think about to avoid that this software depends on undefined behaviour?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@elfring @timiblossom @smukil