Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support BigDecimal in number localization #240

Merged
merged 3 commits into from
Mar 25, 2021
Merged

support BigDecimal in number localization #240

merged 3 commits into from
Mar 25, 2021

Conversation

opoudjis
Copy link
Contributor

This PR adds support to BigDecimal alongside Float and Int as a class of number that can undergo localization. This is necessary in contexts where arbitrary precision numbers need to be localized.

@CLAassistant
Copy link

CLAassistant commented Mar 15, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@opoudjis opoudjis mentioned this pull request Mar 15, 2021
Closed
@coveralls
Copy link

coveralls commented Mar 15, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 96.014% when pulling 3b30317 on metanorma:master into be24d59 on twitter:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 96.013% when pulling 9dc3c05 on metanorma:master into be24d59 on twitter:master.

@camertron
Copy link
Collaborator

Thanks for the PR @opoudjis :)

@opoudjis opoudjis requested a review from camertron March 25, 2021 11:01
@camertron camertron merged commit e0a4626 into twitter:master Mar 25, 2021
@camertron
Copy link
Collaborator

Published in v6.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camertron camertron camertron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@opoudjis @CLAassistant @coveralls @camertron