logback: bump to 1.2.5

Problem We're on an old version of logback Solution Upgrade!! Differential Revision: https://phabricator.twitter.biz/D729767
twitter · Aug 24, 2021 · 0a2bfd6 · 0a2bfd6
1 parent b4a8b44
commit 0a2bfd6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/CHANGELOG.rst b/CHANGELOG.rst
@@ -12,6 +12,8 @@ Runtime Behavior Changes
 
 * Bump version of Jackson to 2.11.4. ``PHAB_ID=D727879``
 
+* Bump version of logback to 1.2.5. ``PHAB_ID=D729767``
+
 21.8.0 (No 21.7.0 Release)
 --------------------------
 

diff --git a/build.sbt b/build.sbt
@@ -12,6 +12,7 @@ val jacksonLibs = Seq(
   "com.fasterxml.jackson.core" % "jackson-databind" % jacksonVersion,
   "com.fasterxml.jackson.module" %% "jackson-module-scala" % jacksonVersion exclude ("com.google.guava", "guava")
 )
+val logbackVersion = "1.2.5"
 val opencensusVersion = "0.19.1"
 val slf4jVersion = "1.7.30"
 
@@ -245,8 +246,8 @@ lazy val twitterServerSlf4jLogbackClassic = (project in file("logback-classic"))
     moduleName := "twitter-server-logback-classic",
     sharedSettings)
   .settings(libraryDependencies ++= Seq(
-    "ch.qos.logback" % "logback-classic" % "1.2.3" % "provided",
-    "ch.qos.logback" % "logback-core" % "1.2.3" % "provided",
+    "ch.qos.logback" % "logback-classic" % logbackVersion % "provided",
+    "ch.qos.logback" % "logback-core" % logbackVersion % "provided",
     "org.slf4j" % "slf4j-api" % slf4jVersion,
     "org.slf4j" % "jcl-over-slf4j" % slf4jVersion,
     "org.slf4j" % "jul-to-slf4j" % slf4jVersion,