"for of" loop is not supported by legacy browsers.

[rcastera]

-Adding babel-polyfill for supporting older browsers
-Resolves #247
-Resolves error ReferenceError: Can't find variable: Symbol in bower_components/twitter-text/js/pkg/twitter-text-2.0.2.js (line 854)

[kaushlakers]

I don't think we need to whole polyfill package for just startsWIth. I've substituted it with substring in this patch.

#244

[rcastera]

@kaushlakers This isn't just for startsWith. I still have an issue with twitter-text running in Phantomjs failing with this error ReferenceError: Can't find variable: Symbol in bower_components/twitter-text/js/pkg/twitter-text-2.0.2.js (line 854).

We have many tests that are failing when upgrading to the newer version of twitter-text due to lack of support. One of your dependencies bundled in the library has the same issue: punycode

This error exists in the travis builds as well: https://travis-ci.org/twitter/twitter-text/jobs/333552627

[rcastera]

See this for an explanation: babel/babel-loader#84

[kaushlakers]

@rcastera good point. I don't think it's twitter-text's responsibility as a text parsing library to polyfill browser features for legacy browsers. We use this polyfill internally.

As a follow up, I can try to raise a PR to the punycode.js lib to replace the "for of" loops. From what I can see, we can safely change it to use a for loop since it is always an array.

[hansott]

You can apply these patches:
https://github.com/engagor/twitter-text/commit/176e1641ca38251d879c36ed56c3f5a2bfc25d86
https://github.com/engagor/punycode.js/commit/467e825a9a54a8a62c58dd591d6e410607089159

[kaushlakers]

@hansott are you planning to raise a PR to punycode or shall I go ahead? :)

[hansott]

@kaushlakers Feel free to do so 😉

[rcastera]

Thanks @kaushlakers @hansott

@kaushlakers will you create a PR to apply this patch as well?

[kaushlakers]

Created this PR. Hoping we can get this merged and published. We can apply @hansott's patch to twitter-text once that is resolved or @rcastera feel free to update this PR to apply that patch. 😄

[rcastera]

@kaushlakers I'll update this PR with the patch. Thanks!

[rcastera]

@kaushlakers updated the PR. I also removed this unused variable

[kaushlakers]

Looks like the rake package command was slightly wrong as it missed a build step. I've updated the README with the correct command. Can you rerun and generate the standalone pkg files again (with the rc tag i.e. 2.0.4-rc1)? Looks like this is missing punycode bundled in.
https://github.com/twitter/twitter-text/blob/master/js/README.md#packaging