Incorrect Slicing

[jithurjacob]

Hi guys in slicing we are using (that.limit -rendered) in this if limit = 5 and rendered = 5 we won't be getting any output right ?

We need to use the minimum value of limit and rendered right ?

function async(suggestions) {
suggestions = suggestions || [];
if (!canceled && rendered < that.limit) {
that.cancel = $.noop;
rendered += suggestions.length;
that._append(query, suggestions.slice(0, that.limit < rendered ? that.limit : rendered));
that.async && that.trigger("asyncReceived", query);
}

This is my first time reporting an issue this solved my problem hope it's correct.

[MerickOWA]

I'm also running into this.

Making the code similar to the function sync(suggestions) { ... } would probably be cleaner..

            function async(suggestions) {
                if (!canceled && rendered < that.limit) {
                    that.cancel = $.noop;
                    suggestions = (suggestions || []).slice(0, that.limit - rendered);
                    rendered += suggestions.length;
                    that._append(query, suggestions);
                    that.async && that.trigger("asyncReceived", query);
                }
            }

Since we do the slice prior to "rendered" getting incremented, we should only slice off as many items as are available to fit within the limit. Since "rendered < that.limit" has already been tested by the if condition, then "that.limit - rendered" would always be positive and equal to the # of remaining items;