Fix limit bug when async update occurs #1451
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When having 0 rendered suggestions, a limit of 5 and a suggestions array with length of 5, nothing will be rendered. This is due to the fact that the "rendered" variable is updated before the suggestions are sliced. With the given PR, everything works as expected.
|
We experienced this bug too. Why is this not merged yet? |
|
+1 On limit 5 the suggestions.length of 3, 4 and 5 will not work properly. Length 1 and 2 seem to work accidentally Workaround could be increasing the limit. |
This was referenced Mar 30, 2016
panthony
added a commit
to cogniteev/typeahead.js
that referenced
this pull request
Jun 13, 2016
|
+1 The commit is identical to the solution I implemented before finding this PR. |
|
+1 |
|
+1 |
|
+1 |
|
Mirko Beine seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
"Mirko Beine seems not to be a GitHub user." vs. https://github.com/mirkobeine ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having 0 rendered suggestions, a limit of 5 and a suggestions array with length of 5, nothing will be rendered.
This is due to the fact that the "rendered" variable is updated before the suggestions are sliced.
With the given PR, everything works as expected.