Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy: Add --strict typings #50

Merged
merged 3 commits into from
Sep 8, 2022
Merged

mypy: Add --strict typings #50

merged 3 commits into from
Sep 8, 2022

Conversation

tony
Copy link
Contributor

@tony tony commented Sep 8, 2022

Fixes #48

To see a list of flags, type mypy --help. As of mypy 0.971 this is max
strictness.

See also: https://mypy.readthedocs.io/en/stable/command_line.html#cmdoption-mypy-strict
We hit the issue at python/mypy#8823
with the Python 3.10 check for MockAwareDocTestFinder on mypy
0.971 (compiled: yes)

logger = logging.getLogger(__name__)


class SphinxDoctestRunner:
def __init__(self, tmpdir):
self.tmpdir = tmpdir
def __init__(self, tmp_path: Path) -> None:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for switiching to tmp_path!

@twmr twmr merged commit 28f8f4d into twmr:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy? (if so, strength?)
2 participants