Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll parent, only need overflowX or overflowY #163

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thonglh
Copy link

@thonglh thonglh commented Feb 22, 2018

To get scroll parent, we are checking for overflow, overflowX, overflowY to match (scroll|auto).
This leads to some issues:

  • For Chrome (I have not checked in the other browser), node.getComputedStyle() will always return empty string for overflow attribute
    So for now, scrollParent(node) always return document.
  • For some reason, we only allow the container to be overflow in one direction and hidden in the other, eg:
overflow-x: hidden;
overflow-y: auto;

This setting will not allow the container to be detected as scrollParent, and this is bad

@thonglh thonglh changed the title Scroll parent, only need overflowX or overflowY Scroll parent, only need overflowX or overflowY Feb 22, 2018
@thonglh
Copy link
Author

thonglh commented Feb 22, 2018

cc @jasonslyvia
Please help!

@vinhlh
Copy link

vinhlh commented Feb 25, 2018

yo yo, any update on these PRs. Love to see this merged.

@ameerthehacker
Copy link
Collaborator

@thonglh I believe this is a duplicate PR for #167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants