Scroll parent, only need overflowX or overflowY #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get scroll parent, we are checking for
overflow, overflowX, overflowY
to match(scroll|auto)
.This leads to some issues:
node.getComputedStyle()
will always return empty string foroverflow
attributeSo for now,
scrollParent(node)
always returndocument
.This setting will not allow the container to be detected as
scrollParent
, and this is bad