Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for any overflow scroll style on parent node. #167

Merged
merged 1 commit into from
Jan 28, 2019

Conversation

rxl881
Copy link
Contributor

@rxl881 rxl881 commented Mar 13, 2018

I believe that the current check for overflow styles is incorrect and that the following patch fixes it (assuming that I'm not misunderstanding how this is meant to be working).

This may (in part at least) fix #96.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 75.904% when pulling 7217cb6 on matrix-org:master into 3dc5c99 on jasonslyvia:master.

@ameerthehacker
Copy link
Collaborator

@rxl881 Thanks for the pull request!

@ChildishDanbino
Copy link

I see this PR has been merged but the latest release doesn't reflect this change. Am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

not working if container has display: flex
4 participants